refactor: Remove dead project routing#5309
Closed
Ma77Ball wants to merge 1 commit into
Closed
Conversation
Ma77Ball
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5309 +/- ##
============================================
- Coverage 49.97% 49.95% -0.02%
Complexity 2421 2421
============================================
Files 1052 1052
Lines 40780 40777 -3
Branches 4356 4355 -1
============================================
- Hits 20378 20369 -9
- Misses 19193 19196 +3
- Partials 1209 1212 +3
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
/request-review @Xiao-zhen-Liu |
Contributor
|
hmm, I thought we agreed to hold off on the issue. were there any updates on the decision? |
Contributor
Author
|
@Yicong-Huang Yes, the plan currently is to avoid removing project routing until a formal decision is made. I wanted this to be a draft pr, but I did not see this option when opening this pr. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
projectandproject/:pidroute definitions fromapp-routing.module.ts, along with the now-unusedUserProjectComponentandUserProjectSectionComponentimports there.type === "project"arm fromListItemComponent.initializeEntryand dropped its now-unusedDASHBOARD_USER_PROJECTimport.Any related issues, documentation, or discussions?
Closes: #5172
How was this PR tested?
yarn format:fix(clean, 514 files unchanged).DASHBOARD_USER_PROJECTreferences remain in the two edited files.list-item.component.spec.tsproject routing test case was already absent, so no spec change was needed.Was this PR authored or co-authored using generative AI tooling?
Co-authored with Claude Opus 4.7 in compliance with ASF